Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBIDE-23862] using latest osjc so that paths to "oc" may have " " #1407

Merged
merged 1 commit into from Feb 8, 2017
Merged

[JBIDE-23862] using latest osjc so that paths to "oc" may have " " #1407

merged 1 commit into from Feb 8, 2017

Conversation

adietish
Copy link
Member

@adietish adietish commented Feb 7, 2017

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?

@adietish
Copy link
Member Author

adietish commented Feb 7, 2017 •
edited

@jeffmaury @bdshadow please +1 this which includes the latest openshift-restclient-java in JBT.

Given that this is a -SNAPSHOT release I have to turn the enforcer rule off and make sure we release and use a final version of the client before the freeze (which I filed to https://issues.jboss.org/browse/JBIDE-23883).
The simple change in the client is the following: openshift/openshift-restclient-java#255

@bdshadow
Copy link
Contributor

bdshadow commented Feb 7, 2017

testPR

1 similar comment
@adietish
Copy link
Member Author

adietish commented Feb 8, 2017

testPR

@adietish
Copy link
Member Author

adietish commented Feb 8, 2017

@bdshadow build finally worked this time. Could you please review this?

bdshadow
bdshadow reviewed Feb 8, 2017
View reviewed changes
plugins/org.jboss.tools.openshift.client/.classpath Outdated
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
<classpathentry exported="true" kind="lib" path="lib/openshift-restclient-java-5.5.0-SNAPSHOT.jar" sourcepath="/openshift-restclient-java"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adietish why has the sourcepath changed? Does it matter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, not really, but good catch, i'll set it back to the source-jar

@adietish
Copy link
Member Author

adietish commented Feb 8, 2017

@bdshadow corrected it

@bdshadow bdshadow merged commit cd50dc6 into jbosstools:master Feb 8, 2017
@adietish adietish mentioned this pull request Feb 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdshadow bdshadow bdshadow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adietish @bdshadow